-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Conversation
I'm doing further investigation into the benchmark with this output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any other weights that got defaulted to 2 trillion? If not, this looks good to me
There, in fact, are, e.g. |
|
@kianenigma Can you comment on the Phragmen weight? |
@apopiak The other XCMs listed are not implemented in the XCM executor, so are also correct, as these XCMs should be invalid. (Maybe there is a better way to denote this). |
Maybe we could pipe some message through the weights generator that ends up as a comment over the weight? |
Both the failed checks should not apply. Can a team lead merge this? @shawntabrizi (Not sure how I'd fix the Cumulus build) |
This PR can probably be superseded by: #4146 |
Something went wrong with the XCM benchmarks for Westend which resulted in the default weight of 2 trillion being used for
ReceiveTeleportedAsset
.This moves that weight back to the previous default of 1 billion so teleport XCMs can be processed.
Also bumps the spec version so the fix can be deployed.
🙏 to @NachoPal for the find.